Updated Edge Handling and GUI Support (Sentry) #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `PersonViewPanel` to display current and total edge without support role-specific logic. - Updated `resetCurrentEdge` logic in `Person` to apply universally instead of being restricted to support roles. - Marked `processWeeklyEdgeResets` in `Campaign` as deprecated, consolidating its usage into `resetCurrentEdge`. - Removed check that prevented non-support characters from having their current Edge levels stored on save.
IllianiBird
added
Bug
Personnel
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6579 +/- ##
============================================
- Coverage 11.42% 11.41% -0.02%
+ Complexity 6456 6451 -5
============================================
Files 1087 1087
Lines 139560 139675 +115
Branches 21584 21615 +31
============================================
- Hits 15950 15947 -3
- Misses 122015 122131 +116
- Partials 1595 1597 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiBird
changed the title
rjhancock
approved these changes
Apr 11, 2025
# Conflicts: # MekHQ/src/mekhq/gui/view/PersonViewPanel.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PersonViewPanelto display current and total edge without support role-specific logic.resetCurrentEdgelogic inPersonto apply universally instead of being restricted to support roles.processWeeklyEdgeResetsinCampaignas deprecated, consolidating its usage intoresetCurrentEdge.Dev Notes
Historically, the expectation was that only techs could use their Edge outside of scenarios. Therefore only techs had their current Edge levels stored in the save file. Everyone else had their current Edge reset to 0 on load.
Furthermore, previously Edge and Current Edge (for techs, nobody else displayed current edge) were displayed on separate lines of the View Person pane. I condensed those into the same line so it appears as shown below.